Thx again -----Original Message----- From: Daniel D. Daugherty Sent: Thursday, December 13, 2012 1:51 PM To: build-dev; serviceability-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net; Ron Durbin Subject: Re: code review request for 7153050 remove crufty '_g' support
Serguei, Thanks for the fast review! I could swear that Ron had removed lines 41 and 45 in an earlier version. Sigh... Will be fixed. Dan On 12/13/12 1:22 PM, serguei.spit...@oracle.com wrote: > Dan, > > It is nice fix and simplified many places. > > Just one minor comment: > > make/bsd/makefiles/dtrace.make > > 41 #LIBJVM_DB = libjvm_db.dylib > 42 LIBJVM_DB = libjvm_db.dylib > > 45 #LIBJVM_DTRACE = libjvm_dtrace.dylib > 46 LIBJVM_DTRACE = libjvm_dtrace.dylib > > The lines #41 and #45 can be removed. > > > Thanks, > Serguei > > > On 12/13/12 10:53 AM, Daniel D. Daugherty wrote: >> Greetings, >> >> I'm sponsoring this code review request from Ron Durbin. This change >> is targeted at JDK8/HSX-25 in the RT_Baseline repo. Please make sure >> you include Ron on any e-mail replies since he is not yet on the >> OpenJDK aliases. >> >> Dan >> >> >> Intro: >> >> This set of changes removes the makefile support for generation of >> debug versions that follow _g semantics. >> >> Defect: >> >> 7153050 "remove crufty '_g' support from HotSpot repo" >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153050 >> https://jbs.oracle.com/bugs/browse/JDK-7153050 >> >> >> Webrev >> >> http://cr.openjdk.java.net/~dcubed/for_rdurbin/7153050-webrev/0 >> >> Details: >> >> Many makefiles have been modified to remove all reference and support >> for debug versions that follow _g semantics. >
