On 8/01/2013 10:56 PM, Erik Joelsson wrote:
The open part of this review. Move handling of --enable-openjdk-only to
before the first custom hook call.
http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/
Minor nit: SUPPRESS has two P's :)
One concern I have with this is that we keep conflating custom and
closed. The OpenJDK build system provides a facility whereby the user
can augment it with custom build files - both at the configure level and
makefile level. The customizations that Oracle builds include are what
we refer to as "closed" and generally involve additional "closed"
repositories in the forest.
In that regard to me --enable-openjdk-only was actually a closed
addition only needed for Oracle closed builds, as a convenience to say
"yes I have a full forest of open and closed parts but ignore the closed
parts and do me an openjdk build".
Magnus argued that any build with customizations is not an OpenJDK
build. But if you follow that line then --enable-openjdk-only should
disable all use of customizations.
What we have now seems to switch back and forth between custom and closed.
Something to clean up at a later time.
Thanks,
David
