On 01/22/13 20:14, Tim Bell wrote: > On 01/22/13 16:02, David Holmes wrote: >> Hi Eric, >> >> On 23/01/2013 4:47 AM, Eric McCorkle wrote: >>> Hello, >>> >>> Please review and approve the makefile changes for JDK-8004729. >>> >>> This patch add a native method (getParameters0) to the Executable class, >>> and uses the JVM_GetMethodParameters function exported from the JVM. >>> >>> http://cr.openjdk.java.net/~emc/8004729/webrev.00/ >>> >>> For more discussion of the feature, see the review on core-libs-dev. >> >> The build changes look okay to me and there is no impact on the new >> build AFAICS. >> >> Tim is also taking a look. > > The build changes look fine to me. > > This is not Makefile related, but I wonder whether you need lines > 33...40 of src/share/native/java/lang/reflect/Executable.c. Is that > #define and comment serving a purpose? I did not find anything similar > in nearby source files. >
It was left-over code that hadn't gotten removed. It's gone now. Thanks for the reviews, all! > Tim >
