These changes look good to me. -kto
On Feb 14, 2013, at 8:24 AM, Erik Joelsson wrote: > Here are a series of patches that adds the following to all native compile > lines on macosx: > > -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 -DMAC_OS_X_VERSION_MIN_REQUIRED=1070 > > This is needed to ensure that no macosx APIs newer than version 10.7 are > used, and will cause compile time errors if they are. > > Normally we would just lock down the build platform to avoid such problems, > but in this case we can't. Newer mac hardware is not compatible with the > older OS versions, forcing us to use newer OS versions on our build systems. > > The hotspot changes will work independent of the rest and can go through rt > as usual. The rest will go into build. > > If a developer feels the need to disable this feature, the make variable > MACOSX_REQUIRED_VERSION can be set to a different version (ex 1080) on the > make command line. > > http://cr.openjdk.java.net/~erikj/8005879/webrev.root.01/ > http://cr.openjdk.java.net/~erikj/8005879/webrev.jdk.01/ > http://cr.openjdk.java.net/~erikj/8005879/webrev.hotspot.01/ > > /Erik