On 14/03/2013 01:26, David Holmes wrote:
:
3. -Werror is set for the SCTP native code causing the build to fail:
Lots of stuff like:
/home/andrew/projects/openjdk/upstream/jdk8/jdk/src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c:88:24:
error: unused parameter 'klass' [-Werror=unused-parameter]
as -Werror is passed and -Wno-unused doesn't seem to turn these off.
SCTP_WERROR=
worked around it (perhaps this should at least be WARNINGS_ARE_ERRORS
to match HotSpot?)
Do we have a preferred way to fix these errors? I know about
__unused__ but I believe this
is GCC-specific and I wouldn't want to break the build on other
platforms (Solaris, MacOS X, BSD).
What gcc version are you using? I don't see this with 4.6.
Probably best to take this up with nio-dev folk.
I'm using 4.6.3 and don't see it either. In any case, this is SCTP so
net-dev is the best place to review a patch to it (but it doesn't
matter, the right people will see it either way).
-Alan
