On 9/04/2013 11:06 AM, Martin Buchholz wrote:
On Mon, Apr 8, 2013 at 5:51 PM, David Holmes <david.hol...@oracle.com <mailto:david.hol...@oracle.com>> wrote:On 9/04/2013 2:59 AM, Andrew Hughes wrote: Well, if I push it, it will be, no? Testing comes before pushing - thank you. This issue keeps coming up. Non-Oracle committers have no access to the Oracle automated testing submission system, so I suggest giving developers some slack when submitting (as I did when I was TL integrator). Or provide some other simple mechanism for handing off risky patches to the integration pipeline. Or provide some easy way to roll back breaking changes.
If you are submitting a build patch that affects multiple platforms and you can not test on all the platforms yourself then you should work with someone who can assist in ensuring sufficient testing is carried out. I don't think that is at all unreasonable.
We have had a number of build related changesets recently (Oracle generated!) that have caused significant build failures on some platforms, which in turn causes significant disruption to a number of teams. So I don't think the importance of testing before pushing can be overstated here.
There's a far greater risk from changes that pass all the tests today, but have a fatal flaw that won't be discovered till after release, IMO.
Totally different problem. David
