On 08/08/2013 03:11 AM, Jonathan Gibbons wrote:
On 08/07/2013 07:10 PM, Stuart Marks wrote:
I'd suggest putting a comment at the top of the test class saying that
this test *must* be run in othervm mode, to ensure that files are
closed properly. That way, you can take out the cleanupFiles() method
too, as well as avoiding lots of exception handling and related
cleanup code.
Huh? What's wrong with
@run main/othervm classname
I think what Stuart is suggesting is that '@run main/othervm classname'
be added, but also an additional text comment explaining why this test
is required to be run in othervm mode.
During various test cleanup efforts over the years I've come across many
tests that specify '@run main/othervm ...' without any obvious reason
why. It is as if it was done (incorrectly) by certain engineers as a
matter of style! Adding a small text comment can be helpful for future
archaeologists ;-)
In this particular case, if a reliable test can be created that runs
only on Mac then that is fine. But if the test is not reliable, or hogs
too much resources, then I think such a source change is ok without a test.
-Chris.
-- Jon
