This looks fine for jdk7u-dev. cheers, dalibor topic
On 8/12/13 5:38 PM, David DeHaven wrote: > > Updated: > http://cr.openjdk.java.net/~ddehaven/8022734/jdk.1/ > > JPRT run was successful, aside from a spurious solaris_sparc_5.10.product > "resource unavailable" error. I re-ran that target to be sure, but I'm pretty > certain it's not related to Mac builds :) > > -DrD- > >> Ah, I didn't realize that. I'll update the patch. >> >> -DrD- >> >>> Hi David, >>> >>> The other *setup targets just do $(RM) -r (since RM is already defined as >>> rm -f). Would look better to follow the same pattern. Otherwise, thanks for >>> fixing it. >>> >>> /Erik >>> >>> On 2013-08-09 22:14, David DeHaven wrote: >>>> This issue has been annoying me for some time, I finally got frustrated >>>> enough to fix it. >>>> >>>> Synopsis: >>>> Running make when a build has already completed will fail when it tries to >>>> symlink libjli.dylib, then (if that's fixed by using "ln -sf") when it >>>> tries to copy the sdk image to j2sdk-server-bundle. This issue has been >>>> around a while, likely just an oversight in rev 5842 which added the >>>> j2sdk-server-bundle target. >>>> >>>> >>>> The fix is simple, blow away the existing j2sdk-server-bundle directory as >>>> it already does with the other two bundles. >>>> >>>> >>>> Just filed so bugs.sun.com entry is not yet available, but when it is: >>>> http://bugs.sun.com/view_bug.do?bug_id=8022734 >>>> >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~ddehaven/8022734/jdk.0/ >>>> >>>> Crusty old build system patch, does not affect 8. Tested against 7u40 and >>>> 7u-dev, submitting JPRT build-only run to test this and a couple other >>>> build system patches. If I don't respond with results we can assume it's >>>> fine. >>>> >>>> >>>> Will need a Committer to push to 7u-dev for me, I think it's probably too >>>> late for 7u40. >>>> >>>> -DrD- >>>> >> > -- Oracle <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
