Nice, thanks. On 8/21/13 2:53 PM, Erik Joelsson wrote: > Thanks, updated webrev: > > http://cr.openjdk.java.net/~erikj/8023216/webrev.root.02/ > > /Erik > > On 2013-08-19 16:38, Dalibor Topic wrote: >> On 8/19/13 2:43 PM, Erik Joelsson wrote: >>> And again, here we go: >>> >>> http://cr.openjdk.java.net/~erikj/8023216/webrev.root.01/ >> A few typos: >> >> javascript -> JavaScript >> sourses -> sources >> >> cheers, >> dalibor topic >> >> >>> /Erik >>> >>> On 2013-08-19 11:05, Erik Joelsson wrote: >>>> Thanks for the feedback! >>>> >>>> I took most of it and made into a change. Also removed some obsolete parts >>>> that I stumbled over. >>>> >>>> Warn is supposed to be quiet, but at least hotspot is still being quite >>>> noisy. >>>> >>>> /Erik >>>> >>>> On 2013-08-06 01:18, Dan Smith wrote: >>>>> I'm building for the first time under the new infrastructure (late to the >>>>> party, I know). I appreciate the comprehensive readme page. Here's a >>>>> list of minor points of feedback: >>>>> >>>>> "The set of repositories and what they contain": need to add nashorn >>>>> >>>>> "warn — Default and very quiet": I presume this is still an in-progress >>>>> goal? I'm seeing almost 3000 lines of text in a fresh build (including >>>>> over 1000 from 'images') >>>>> >>>>> --- >>>>> >>>>> Some copy editing: >>>>> >>>>> "each repository is it's own independent repository": it's -> its >>>>> >>>>> "Insure that GNU make": insure -> ensure >>>>> >>>>> "rather thane excludes": thane -> than >>>>> >>>>> "Other depends on pieces of code": other depends -> others depend >>>>> >>>>> "for all classes that contains constants": contains -> contain >>>>> >>>>> "we have missed to add support": missed -> neglected >> >>
-- Oracle <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
