Hi Ioi, I'd suggest that the next time rules.make gets modified - the default version of VS should become VS2010, not 2003 as it is now.
0.02, Ivan On Aug 27, 2013, at 8:55 AM, Yumin Qi <yumin...@oracle.com> wrote: > Looks good to me. > > Thanks > Yumin > > On 8/26/2013 6:17 PM, Ioi Lam wrote: >> Please review a very small fix: >> >> http://cr.openjdk.java.net/~iklam/8020622/vs2012_proj_001/ >> >> Bug: create.bat on Windows failed to create project file for Visual Studio >> 2012 >> >> https://bugs.openjdk.java.net/browse/JDK-8020622 >> >> Summary of fix: >> >> Treat VS2012 as VS2010. The generated project will be automatically >> upgraded to VS2012 format by the IDE. >> >> Tests: >> >> I built X64 and X86 VMs inside VS2012 and ran Eclipse. >> JPRT >> >> Thanks >> - Ioi >> >
