Looks ok to me as well
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Oct 1, 2013, at 5:32 AM, Chris Hegarty <chris.hega...@oracle.com> wrote: > The changes look ok to me Mike. Thanks, > > -Chris, > > On 09/30/2013 09:48 PM, Mike Duigou wrote: >> Hello all; >> >> When JDK-8006709 (http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/cff8d7768d72) >> was pushed it changed the default source level for the jdk project NetBeans >> projects to 1.8. This was a reasonable change since at this point there was >> already a small amount of Java 8 "-source 1.8" code in the jdk repo. Since >> that time the amount of source has increased. This change meant, >> unfortunately, that it was no longer possible to use a release version of >> netbeans as 7.3 did not support Java 8 source. Users wanting to use the jdk >> projects had to use either special lambda builds of NetBeans or the nightly >> dev builds. >> >> NetBeans 7.4 will support Java 8 source. This changeset adjusts the projects >> so that they are recognized by NetBeans. The same change also works with >> NetBeans dev and lambda builds. >> >> http://cr.openjdk.java.net/~mduigou/JDK-8025686/0/webrev/ >> >> In addition to updating the projects this change also adjusts the location >> where classes would be written (assuming that compilation from within >> NetBeans wasn't broken--it is currently broken). This change is incomplete >> in that it doesn't properly understand the SPEC variable from the new >> makefiles but at least it prevents writing output to the repo directory. >> This will be further cleaned up in JDK-8016210 >> (https://bugs.openjdk.java.net/browse/JDK-8016210) >> >> Cheers, >> >> Mike >>
