Unfortunately, the patch failed when I tried submitting it. Usage of the ListPathsSafely macro in SetupArchive is a bit different and needs to be adjusted. Here is a webrev that I have verified to work:

http://cr.openjdk.java.net/~erikj/8025921/webrev.root.01/

I also reduced duplication and slightly changed the debug message. At least to me, assuming word 2 of $3 to be a filename feels a bit of a hack, even if it's usually the case.

/Erik

On 2013-10-04 09:52, Erik Joelsson wrote:
This is a great idea and the patch looks good to me.

/Erik

On 2013-10-04 09:29, Magnus Ihse Bursie wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8025921

The primary purpose of the LOG=debug level is to display the actual commands run by make.

However, they are often buried in long output lists of filenames, by the ListPathsSafely macro and the dependency lists for the SetupArchive marco, making it hard to find the relevant output.

The output of these lists are of less relevance, and should be pushed down to the more verbose LOG=trace level.

WebRev: http://cr.openjdk.java.net/~ihse/JDK-8025921-make-LOG-debug-more-readable/webrev.01

/Magnus




Reply via email to