On 10/10/13 12:01, Alan Bateman wrote:
On 10/10/2013 11:10, Michael McMahon wrote:
Can I get the following change for jdk 8 reviewed please?
It's a simple build change to enable compilation of the dummy
SCTP API layer on macosx, plus the dummy implementation
used on windows.
The existing jdk_sctp tests cover this.
http://cr.openjdk.java.net/~michaelm/7076487/webrev.1/
This looks okay to me (I didn't look at the Sctp* sources closely as I
assume they are just a copy of the dummy implementation from
src/windows).
Yes. That's what I meant to say. The sources are copied from the windows
tree. They just throw
UnsupportedOperationException, but it means that Sctp tests can be
compiled on all the reference platforms now.
A minor comment (a question) is whether there is a convention to sort
the values of EXFILES or not. If there is then you might have to
re-order them.
Right. I'll defer to someone from build on that question.
Thanks
Michael
