On 14/10/2013 7:25 PM, Erik Joelsson wrote:
Please review the following changes, correcting the conditions for when
to build certain parts of the servicability features. Instead of
guarding them with the OPENJDK variable, they need to be conditioned on
the existence of the source itself.
In hotspot, this only fails on Windows. The linux makefiles already
check on the existence of the source rather than if it's an OPENJDK
build. This change makes windows do the same.
http://cr.openjdk.java.net/~erikj/8019540/webrev.hotspot.01/
This is an expedient fix.
More generally though these kinds of things should really be in the
closed makefiles. That of course requires a suitable closed makefile
which doesn't presently exist.
In JDK, it fails on all platforms. There is already a configure
variable, ENABLE_JFR, that seems to be set correctly for this case.
http://cr.openjdk.java.net/~erikj/8019540/webrev.jdk.01/
Ok.
I will need a sponsor to push this to hotspot if it passes review.
You will need a separate bug for the JDK and hotspot side due to the
different version info used by each. Otherwise the hgupdater will get in
a tangle with the backports.
David
-----
/Erik
