On 2013-10-22 19:54, Volker Simonis wrote:

Well, I don't think so. As far as I can see it is used for everything which is not Windows and not Solaris in Awt2dLibraries.gmk:

+  else ifeq ($(OPENJDK_TARGET_OS), solaris)
      LIBSPLASHSCREEN_CFLAGS += -DWITH_X11 -I$(OPENWIN_HOME)/include 
-I$(OPENWIN_HOME)/include/X11/extensions
  else
-    LIBSPLASHSCREEN_CFLAGS
+= -DWITH_WIN32
+ LIBSPLASHSCREEN_CFLAGS += -DWITH_X11 $(X_CFLAGS) -I$(OPENWIN_HOME)/include/X11/extensions endif Or am I missing something?

No, you are not missing anything. :-) You are absolutely correct; however, the -I$(OPENWIN_HOME)/include/X11/extensions was not supposed to be there except for Solaris. Erik must have missed to remove it when copying the CFLAGS line, just as I missed it when reviewing.

Good catch!

With the non-Solaris-and-non-Window line reading
LIBSPLASHSCREEN_CFLAGS += -DWITH_X11 $(X_CFLAGS)
instead, I hope you can agree with my statement. :)

/Magnus

Reply via email to