Thanks. Build side looks fine to me.
David
On 25/03/2014 6:09 AM, Alexander Smundak wrote:
Done. Uploaded
http://cr.openjdk.java.net/~martin/asmundak/8036767/hotspot/webrev.05
On Sun, Mar 23, 2014 at 8:37 PM, David Holmes <david.hol...@oracle.com> wrote:
On 22/03/2014 10:47 AM, Alexander Smundak wrote:
On Fri, Mar 21, 2014 at 2:55 PM, Lindenmaier, Goetz
<goetz.lindenma...@sap.com> wrote:
My build ran into the 'little' case below, as I understand because ' big'
was compared
with 'big'. Make is strange ...
Removed the spaces, please take a look at
http://cr.openjdk.java.net/~martin/asmundak/8036767/hotspot/webrev.04
Stylistically the hotspot makefiles test a variable/expression against a
value/constant not the other way around. So:
ifeq (undefined,$(origin OPENJDK_TARGET_CPU_ENDIAN))
becomes
ifeq ($(origin OPENJDK_TARGET_CPU_ENDIAN),undefined)
and the same for all the other comparisons you have added.
Sorry.
David
