Looks good to me. /Magnus
> On 3 apr 2014, at 10:08, Erik Joelsson <erik.joels...@oracle.com> wrote: > > Hello, > > Please review this small fix, correcting the contents of the zipped debuginfo > files. They are currently adding the full absolute path name of the debuginfo > files to the zip instead of just the filename. > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8035134 > Patch inline: > diff -r 54dd5b81ed46 make/common/NativeCompilation.gmk > --- a/make/common/NativeCompilation.gmk > +++ b/make/common/NativeCompilation.gmk > @@ -482,7 +482,7 @@ > # to be rebuilt properly. > $$($1_DEBUGINFO_ZIP): $$($1_DEBUGINFO_FILES) $$($1_TARGET) > $(CD) $$($1_OBJECT_DIR) \ > - && $(ZIP) -q $$@ $$($1_DEBUGINFO_FILES) > + && $(ZIP) -q $$@ $$(notdir $$($1_DEBUGINFO_FILES)) > > else > $1 += $$(subst > $$($1_OBJECT_DIR),$$($1_OUTPUT_DIR),$$($1_DEBUGINFO_FILES)) > > > /Erik
