On 4/7/14 11:54 AM, Chris Hegarty wrote:
Updated webrev: http://cr.openjdk.java.net/~chegar/8039362/01/webrev/
Thanks for doing this. Some minor comments:line 225: since content-types.properties is moved to the same package as MimeType class, you can simply use the relative path "content-types.properties" to get the resource stream
line 240: should we expect it always exist? Perhaps an assert. I wonder if this can be refactored so that it can use try-with-resources. thanks Mandy