Looks good! Mike
On Apr 16 2014, at 01:07 , Erik Joelsson <erik.joels...@oracle.com> wrote: > > On 2014-04-16 09:14, Erik Joelsson wrote: >> >> On 2014-04-15 18:41, Mike Duigou wrote: >>> I am curious why you didn't make it conditional based upon DEBUG_LEVEL like >>> jdk and corba? It would be difficult/annoying to turn it on if needed. >> But it is. If debug level is set to something debug, configure sets >> JAVAC_FLAGS to -g and this gets picked up by SetupJavaCompilation.gmk >> automatically. >>> The name "GENERATE_NEWBYTECODE_DEBUG" is also confusing since the bytecode >>> is not tuned for debugging. >> That is true. Will change that name. >> > New patch with the names corrected: > http://cr.openjdk.java.net/~erikj/8040267/webrev.01/ > > /Erik
