----- Original Message ----- > Hi Omair, > > This seems harmless for OPENJDK builds. > > David > > On 29/05/2014 9:33 AM, Omair Majid wrote: > > Hi, > > > > Webrev: > > http://cr.openjdk.java.net/~omajid/webrevs/8044235-src-zip-include-all/00/ > > > > The src.zip file produced in an OpenJDK build contains the code for a > > subset of the Java class library. Developers who wish to debug their > > program and step into the source of a class that's part of the Java > > class library are often disappointed when they find that their IDE can > > not do that because src.zip does not include the source for the class. > > > > The webrev basically stops the filtering and includes all sources in > > src.zip. > > > > I noticed a glitch unrelated to the patch: somehow the src.zip ends up > > containing the source for launcher, which is in C, too. But this happens > > without the patch too, so it's not a regression. > > > > Thanks, > > Omair > > >
Looks good to me too. There's no need to exclude source files from the open build. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
