Hello David,

Looks pretty good. A couple of questions still:

* Where is the AC_SUBST for SDKROOT?

* Could we get the "Checking for Xcode sdk name" output to only print on macosx?

* Why remove MACOSX_VERSION_MIN=@MACOSX_VERSION_MIN@? I believe we still use this in some closed makefiles. Or is the idea that we instead will force the sdk name to 10.7? If so, then we need to still leave this in until every user (RE) has switched properly.

/Erik

On 2014-05-30 16:49, David DeHaven wrote:
Here's the latest patch set:
http://cr.openjdk.java.net/~ddehaven/8043340/v2/
Just FYI, I ran a build only job on JPRT and it passed:
Build Stats:        14 pass, 0 fail, 0 killed, 0 working, 0 initializing, 0 not 
started

-DrD-


Reply via email to