At some point I mean. It's ok to not do it as part of this change.
/Erik
On 2014-06-09 10:06, Erik Joelsson wrote:
It certainly should be updated.
/Erik
On 2014-06-05 23:51, David DeHaven wrote:
Will README-builds.html be updated as part of the compiler update? It
(will be) outdated.
I don't think it needs to be part of this patch since I'd like to
backport this (and the other patches I've contributed recently) to 8u
after it incubates for a while.
-DrD-
Only thing I can think of now is that some of the error/warning
messages do not start with a capital letter. Looks good and nice work!
I'll fix those before pushing.
I also removed using SDKROOT from the env, since we ignore the
environment. Only two args affect SYSROOT now, --with-sysroot and
--with-sdk-name.
I think that's good too, I had some doubts about that. Is that
environment variable set by the system in some way or is it
something one sets manually? If it's something the system sets,
then perhaps it's worth looking at (compare VS100COMNTOOLS on
windows which points to visual studio). But since we can get the
information from xcodebuild anyway, it really doesn't matter.
Right. SDKROOT is set when Xcode is building, so it would either be
set by the user or if someone were building OpenJDK as part of an
Xcode project.
Nice to see a speedup in building too. The broken case seems ok to
me. Not much we can do there. Silently switching to clang would be
bad too.
Agreed!
-DrD-
