Quick update:
I downloaded the jigsaw stage repo and tried the build. The biggest issue is that it requires Ant 1.9.4 (because of the MuliRootFileSet) to work, but after that is set up, everything works like before. My IntelliJ setup needed few cosmetic changes, to update the source roots, but nothing out of the ordinary. Overall, I'm pretty satisfied with it.

Maurizio

On 15/08/14 14:17, Erik Joelsson wrote:

On 2014-08-15 14:54, Maurizio Cimadamore wrote:
I'm looking at the langtools-related changes in build.xml; I what is the degree of support available in the build.xml ant file for the Jigsaw world? It seems to me that not all the target would function and it also seems that some of the properties previously encoded in a side property file (make/build.properties) have now been inlined in the build.xml file itself, which seems problematic maintenance-wise. Am I missing something?

As far as I know, build.xml has so far been supported by the langtools team themselves and all changes to the file in this patch have been made by them. Jon may have something to say?

/Erik

Maurizio

On 12/08/14 15:10, Chris Hegarty wrote:
This is a review request for the Initial changes for JEP 201: Modular Source Code [1].

There are a number of individuals responsible for these changes. Some, possibly not all, are explicitly listed in the To section of this mail, and they will help address any comments arising from this review request.

For the purposes of review, the actual source file moves have been omitted from the webrev below, with the exception of any source file that has a change to it’s actual content. The new location of the source files can be determined from JEP 201 [1] and JEP 200 "The Modular JDK" [2], or by browsing the staging forest [3].

Webrevs:
  http://cr.openjdk.java.net/~chegar/8054834/00/

Due to the significant impact of these changes, a JDK 9 promotion has been tentatively reserved for their integration. All comments are welcome, although given the nature of the changes then we might have to create separate issues in JIRA to address some of them later in jdk9/dev..

-Chris.

[1] https://bugs.openjdk.java.net/browse/JDK-8051619
[2] https://bugs.openjdk.java.net/browse/JDK-8051618
[3] http://hg.openjdk.java.net/jigsaw/stage



Reply via email to