On 25/08/2014 14:48, Staffan Larsen wrote:
Please review this change to remove the legacy JPDA demos. These demos are 
quite dated at this point and the included instructions are incomplete. In 
addition the example/demo JPDA code does not fit well into the new modular 
structure because the source code is used for both jdb and for the demo.

bug: https://bugs.openjdk.java.net/browse/JDK-8043981
webrev: http://cr.openjdk.java.net/~sla/8043981/webrev.00/

Good to see this going away, it also addresses one of Magnus' recent comments here about jpda/src.zip being built from sources in two locations (a consequence of the code being used for two things).

The changes looks okay to me. A passing comment is that the move of Expr.jj is a reminder that we have generated code checked-in but that has been the case for a long time.

-Alan.

Reply via email to