Hi Mandy, I'm seeing some small differences in the various VirtualMachineImpl.java files, but if I'm not mistaken, all the new AttachProviderImpl.java look all the same. I wonder if the patch could be further simplified by moving AttachProviderImpl.java to jdk.attach/share/classes (unless there's a reason to keep all the different copies)...
best regards, -- daniel On 8/26/14 6:29 AM, Mandy Chung wrote:
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055230/ This patch renames the class name of attach provider implementation class to be the same for all platforms. This simplifies the build logic and removes the need for generating the service config file at build time. The files renamed are unix/classes/sun/tools/attach/${OS}VirtualMachine.java -> ${OS}/classes/sun/tools/attach/VirtualMachineImpl.java unix/classes/sun/tools/attach/${OS}AttachProvider.java -> ${OS}/classes/sun/tools/attach/VirtualMachineImpl.java ${OS}/classes/sun/tools/attach/${OS}VirtualMachine.java -> ${OS}/classes/sun/tools/attach/VirtualMachineImpl.java ${OS}/classes/sun/tools/attach/${OS}AttachProvider.java -> ${OS}/classes/sun/tools/attach/VirtualMachineImpl.java and also corresponding native files. Mandy