Thanks for pointing this out. That is indeed a better and more portable
solution. I took the liberty of creating a new bug and creating a patch
reverting my earlier change and using this instead.
Bug: https://bugs.openjdk.java.net/browse/JDK-8056064
Webrev: http://cr.openjdk.java.net/~erikj/8056064/webrev.01/
/Erik
On 2014-08-23 17:32, Ludovic HOCHET wrote:
Hello Erik,
This does not fix the issue for me on a Win 8.1 fr_FR. I still have
creation dates in French.
eg.:
Compiling 1478 files for java.corba
c:\dev\dev\build\windows-x86_64-normal-server-release\corba\gensrc\java.corba\com\sun\corba\se\spi\activation\Activator.java:8:
error: unmappable character for encoding ascii
* samedi 23 ao?t 2014 16 h 50 CEST
Forcing the en locale on the Java run of IDLJ fixes the issue for me:
diff -r 4d704afddadd make/GensrcCorba.gmk
--- a/make/GensrcCorba.gmk Mon Aug 18 10:07:13 2014 +0100
+++ b/make/GensrcCorba.gmk Sat Aug 23 15:41:15 2014 +0100
@@ -51,7 +51,7 @@
EXCLUDE_FILES := ResourceBundleUtil.java))
TOOL_IDLJ_CMD := $(JAVA) -cp $(CORBA_OUTPUTDIR)/idlj_classes \
- com.sun.tools.corba.se.idl.toJavaPortable.Compile
+ -Duser.language=en com.sun.tools.corba.se.idl.toJavaPortable.Compile
################################################################################
Rgds,
On Wed, Aug 20, 2014 at 10:55 AM, Erik Joelsson
<erik.joels...@oracle.com> wrote:
Hello,
Please review this minor patch which makes the build work on a ja_JP locale.
Bug: https://bugs.openjdk.java.net/browse/JDK-8055405
diff -r c72d6edec4cf make/common/IdlCompilation.gmk
--- a/make/common/IdlCompilation.gmk
+++ b/make/common/IdlCompilation.gmk
@@ -60,7 +60,7 @@
$(RM) -rf $3/$$($4_TMPDIR)
$(MKDIR) -p $(dir $5)
$(ECHO) $(LOG_INFO) Compiling IDL $(patsubst $2/%,%,$4)
- $8 -td $3/$$($4_TMPDIR) \
+ LC_ALL=C $8 -td $3/$$($4_TMPDIR) \
-i $2/org/omg/CORBA \
-i $2/org/omg/PortableInterceptor \
-i $2/org/omg/PortableServer \
/Erik
