On 2014-08-26 16:27, Alan Bateman wrote:
On 26/08/2014 13:46, Erik Joelsson wrote:
Hello,
Please review this small patch fixing a couple of issues that have
been raised on this list following the source code restructure.
* Fix spelling error in make help (build->built)
* Readd the jdk target as an alias for exploded-image as people are
used to the target and the error message when it's missing is confusing.
* Print a warning when clean targets and other targets are mixed on
the command line as this won't work well. Also add a note about this
in the help target.
Bug: https://bugs.openjdk.java.net/browse/JDK-8056062
Webrev: http://cr.openjdk.java.net/~erikj/8056062/webrev.root.01/
This looks okay to me, I'm just wondering whether an attempt to mix
clean with other targets should be an error rather than a warning.
Thanks!
As far as I can tell, it still works, it will just be slower on a
multicore machine. It will also not print the summary at the start and
end of the build. So I think a warning is enough, but you might have a
point in trying to discourage it even more.
/Erik
