On 8/28/14 1:32 AM, Magnus Ihse Bursie wrote:
On 2014-08-27 18:00, Mandy Chung wrote:
Erik, Magnus,
This is much easier than I have thought. I really like this new build.
Glad to hear! :)
I have separated out Gendata-jdk.dev.gmk and removed the modules-xml
target completely.
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055856/webrev.01/
Looks good, but I still think the CheckModules.gmk file should be in
$TOP/make/ instead of jdk/make. As a rule of thumb, stuff working on
"all modules" should sit in the top level, but stuff working on a
specific module should sit close to that module. Apart from that, it
looks great.
Agree. It should be moved to the top repo. jdk/make/ModulesXml.gmk was
added while the modular build was undergoing various change/reorganized.
I will move it.
Mandy
