On 9/12/14 7:03 AM, Erik Joelsson wrote:
Hello,
The checked in modules.list file defines the dependencies between
modules for the build. The dependency information in this file is
already captured in the modules.xml. Rather than keeping two copies of
this information, with this change, modules.list is generated during
the build.
Chris provided the java implementation for the actual list generation.
I've made the makefile changes.
Bug: https://bugs.openjdk.java.net/browse/JDK-8058118
Webrevs: http://cr.openjdk.java.net/~erikj/8058118/
Looks okay. A couple minor comments on the build tool:
build/tools/module/GenModulesList.java
line 104: maybe s%x%d% to make it little clear as dependence.
filter(GenModulesList::isNotAggregator) is done in several places.
Would it be better to do the filtering when writing out modules.list
in line 85 and 86?
Nit: line 82 - it may be clearer to rename sort to topoSort to make
it clear or simply inline line 98-99.
Mandy
