On 2014-09-15 10:26, Erik Helin wrote:
On 2014-09-12 17:17, Erik Joelsson wrote:
Hello Erik,

Looks good to me.

Thanks!

On 2014-09-12 17:17, Erik Joelsson wrote:
Don't forget to also push the generated-configure.sh
files.

Since this is the first time I'm pushing a change to the top-level build system, are the following steps the preferred way of updating generated-configure.sh?

$ sh common/autoconf/autogen.sh
This is correct.
$ hg add common/autoconf/generated-configure.sh

No need to add the file, as it's already under mercurial control. Just commit in both the root repo and the root/closed repo.

/Erik
Thanks,
Erik

/Erik

On 2014-09-12 17:05, Erik Helin wrote:
Hi all,

the top-level Makefiles are using the target jvm in the HotSpot
Makefiles when configured with --debug-level=slowdebug. The jvmg
target has been deprecated in the HotSpot Makefiles, the debug target
should be used instead.

This small patch changes jdk-options.m4 to use the debug target
instead of jvmg.

Bug: https://bugs.openjdk.java.net/browse/JDK-8058317

Webrev: http://cr.openjdk.java.net/~ehelin/8058317/webrev.00/

Testing:
- JPRT
- Verified manually on personal machine that the debug target is now
  being used.

Thanks,
Erik


Reply via email to