On 15/10/14 17:19, shanliang wrote:
Here is the new version:
http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/
The new version looks fine :-)
-- daniel
I add:
./01/jdk9-make/
for updating ./make/CompileJavaModules.gmk
./01/jdk9-jdk-src/ is same to ./00
Thanks,
Shanliang
Erik Joelsson wrote:
Hello,
Removing the excludes would be appreciated. Here is a patch:
diff -r c173ba994245 make/CompileJavaModules.gmk
--- a/make/CompileJavaModules.gmk
+++ b/make/CompileJavaModules.gmk
@@ -247,14 +247,6 @@
# Exclude building of IIOP transport for RMI Connector
java.management_EXCLUDES := com/sun/jmx/remote/protocol/iiop
-# Why is this in the open source tree?
-ifdef OPENJDK
- java.management_EXCLUDES := \
- com/sun/jmx/snmp \
- sun/management/snmp \
- #
-endif
-
ifeq ($(RMICONNECTOR_IIOP), false)
java.management_EXCLUDES += com/sun/jmx/remote/protocol/iiop
endif
/Erik
On 2014-10-15 15:46, Alan Bateman wrote:
On 15/10/2014 14:35, shanliang wrote:
Hi,
SNMP is not part of OpenJDK and SNMP packages are not compiled in
OpenJDK, so the SNMP sources should be deleted from the OpenJDK
Bug: https://bugs.openjdk.java.net/browse/JDK-8060692
Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8060692/00/
The code removal looks good but don't you also need to update make
make/CompileJavaModules.gmk in the top-level remove to remove the
snmp directories from java.management_EXCLUDES ?
-Alan.
