Thanks, looks good.
/Erik
On 2014-10-18 01:48, Valerie Peng wrote:
Ok, I have updated the Copy-java.base.gmk with your suggestion, i.e.
folded the ifndef part into the previous ifeq.
Webrev updated:
http://cr.openjdk.java.net/~valeriep/8046002/webrev.02/
Thanks!
Valerie
On 10/16/2014 1:00 AM, Erik Joelsson wrote:
Hello Valierie,
In Copy-java.base.gmk, you could change the findstring construct to a
simple "ifeq ($(OPENJDK_TARGET_OS), windows)", perhaps even fold the
whole ifndef OPENJDK into the previous ifeq since they are now the same.
Otherwise it looks good to me.
/Erik
On 2014-10-15 20:46, Valerie Peng wrote:
Hi, build experts,
Could you please review the build-related changes for 8046002: Move
Ucrypto to the open jdk repo?
The rest (src/test) has been reviewed by my peers in security team.
Bug: https://bugs.openjdk.java.net/browse/JDK-8046002
Webrev: http://cr.openjdk.java.net/~valeriep/8046002/webrev.01/
Thanks,
Valerie
