On 01/08/2015 11:38 AM, Erik Joelsson wrote:
> Hello Roman,
>
> Thanks for the full patch!
>
> I discovered a problem with the top repo patch. When autoconf (using m4)
> evaluates your change, the brackets disappear. To fix this, more
> brackets need to be added. Here is a version that works for me that will
> make the correct sed expression appear in the generated file:
>
> diff -r 7063bdada583 common/autoconf/libraries.m4
> --- a/common/autoconf/libraries.m4
> +++ b/common/autoconf/libraries.m4
> @@ -1080,7 +1080,7 @@
> fi
> fi
> done
> - llvm_version=$("${LLVM_CONFIG}" --version | sed 's/\.//; s/svn.*//')
> + llvm_version=$("${LLVM_CONFIG}" --version | sed [
> 's/\(^[0-9]\)*.\([0-9]*\).*/\1\2/; s/svn.*//' ])
> LLVM_CFLAGS="${LLVM_CFLAGS} -DSHARK_LLVM_VERSION=${llvm_version}"
>
> unset LLVM_LDFLAGS
>
> I tried building locally (Ubuntu 14.04 with llvm 3.4) but it failed with
> undefined references at link time:
>
> /usr/lib/llvm-3.4/lib/libLLVMSupport.a(Process.o): In function
> `llvm::sys::Process::FileDescriptorHasColors(int)':
> (.text+0x5b7): undefined reference to `setupterm'
> /usr/lib/llvm-3.4/lib/libLLVMSupport.a(Process.o): In function
> `llvm::sys::Process::FileDescriptorHasColors(int)':
> (.text+0x5e0): undefined reference to `tigetnum'
> /usr/lib/llvm-3.4/lib/libLLVMSupport.a(Process.o): In function
> `llvm::sys::Process::FileDescriptorHasColors(int)':
> (.text+0x5e9): undefined reference to `set_curterm'
> /usr/lib/llvm-3.4/lib/libLLVMSupport.a(Process.o): In function
> `llvm::sys::Process::FileDescriptorHasColors(int)':
> (.text+0x5f1): undefined reference to `del_curterm'
> collect2: error: ld returned 1 exit status
That should be in the ncurses-devel package (or whatever it's called on
Ubuntu) which I thought was an OpenJDK requirement anyway. Maybe the
only problem is that we're not linking with -lncurses.
Andrew.
