And the webrev link: http://cr.openjdk.java.net/~erikj/8069261/webrev.03/
/Erik
On 2015-01-23 14:35, Erik Joelsson wrote:
Hello,
New webrev:
On 2015-01-23 13:34, Magnus Ihse Bursie wrote:
On 2015-01-23 12:17, Erik Joelsson wrote:
* Added test-make to the all target so that it gets tested in JPRT.
It takes close to no time to run.
While I do like to see the make tests being run more frequently, I'm
not sure I like the idea of adding them to the "all" target. I think
building and testing should be kept as separate as possible, even if
it matters testing the build system.
If your goal is to get it run in JPRT, why not add it to the JPRT
bundles target instead?
Removed it for now.
* For SetupArchive, I discovered that for vardeps changes, we have
to force a full recreation of the jar to be sure those changes are
really picked up. I also discovered that we currently didn't rebuild
a jar if the manifest template file was changed. (I'm happy I had
test-make tests for SetupArchive when fixing this.)
Great! :-)
Seems like it could be a good thing to add a test that changes to the
manifest file trigger a build? :-) (The current test seems to bundle
manifest updating with other changes which could by themselves
trigger the update.)
Implemented.
/Erik
