Thanks, looks much better to me at least.

/Erik

On 2015-02-06 11:57, Magnus Ihse Bursie wrote:
On 2015-02-05 12:44, Erik Joelsson wrote:
Looks good to me, but if it's possible, please split that huge echo line. Adding a $$(strip ) will likely remove any extra white space introduced by the split and indentation.

I'm not sure it's much clearer. :-) However, the lines are indeed shorter, and it's probably not much worse either. :)

New webrev:
http://cr.openjdk.java.net/~ihse/JDK-8072106-make-dependency-targets-generation/webrev.02/

/Magnus


Reply via email to