On 04/15/15 06:12, Magnus Ihse Bursie wrote:
On windows, many executables have an assembly manifest embedded. This sets among other things the JDK version. Our current handling of this is sub-optimal, using template files that are modified at build time. Instead, a command line option to MT, the manifest processor, can be used.

Thanks for the trip down memory lane! We worked with manifests back in the VS 2005 and 2008 time-frame [1] :-)

At places we also try to include manifest information twice, using the old style of declaring the manifest file in an .rc file. This is not needed when we use MT for post-processing.

Bug: https://bugs.openjdk.java.net/browse/JDK-8077847
WebRev: http://cr.openjdk.java.net/~ihse/JDK-8077847-better-windows-manifest/webrev.01

Looks good to me.

Tim

[1] https://bugs.openjdk.java.net/browse/JDK-6523947
     https://bugs.openjdk.java.net/browse/JDK-6816366
      and several others...

Reply via email to