On 2015-05-06 11:39, Erik Joelsson wrote:
This one looks better. Sorry for not spotting the problem in the
previous review.
/Erik
On 2015-05-06 11:24, Staffan Larsen wrote:
My fix for 8079248 was broken, so here is a new attempt. I intend to
push this directly to jdk9/hs since that is where 8079248 was pushed.
bug: https://bugs.openjdk.java.net/browse/JDK-8079345#comment-13638237
webrev: http://cr.openjdk.java.net/~sla/8079345/webrev.00
<http://cr.openjdk.java.net/~sla/8079345/webrev.00>
Looks good to me. If you care, maybe you could move (and properly
indent) the comment about the flag to inside the "if windows" clause?
You don't need to respin the webrev if you do that.
/Magnus