Thanks for the update. Looks good! This change is very nice.
I verified on an old Solaris machine that OBJCOPY is empty when the
version is 2.15.
/Erik
On 2015-09-11 09:32, Magnus Ihse Bursie wrote:
On 2015-09-10 23:41, Magnus Ihse Bursie wrote:
Objcopy on Solaris prior to 2.21.1 is broken and will either crash
during runtime or produce an incorrect result. We have traditionally
handled this using two helper binaries that does the work of objcopy,
but this has been error prone and is not a really nice solution. And
by now, a fixed version of objcopy has been long time available in
Solaris.
We should implement the same solution in configure as the fix for
JDK-8033602 in hotspot, that is, to check the version of objcopy on
solaris, and just disable use if it is old and broken.
This will allow us to remove the cumbersome helper tools that were
developed to work around these limitations.
Bug: https://bugs.openjdk.java.net/browse/JDK-8064808
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8064808-disable-broken-objcopy-on-solaris/webrev.01
I noticed that I left some debug code in toolchain.m4, and also didn't
use variables like $SED for the commands.
I might also add that the compex sed expression is copied from the
corresponding check in the hotspot makefiles.
Updated webrev: (only changed in toolchain.m4)
http://cr.openjdk.java.net/~ihse/JDK-8064808-disable-broken-objcopy-on-solaris/webrev.02
/Magnus
