Looks good. Thanks,
Bertrand (not a Reviewer). On 18/09/2015 00:44, Ioi Lam wrote:
Please review a small fix: http://cr.openjdk.java.net/~iklam/8065155-refactor-hotspot-mapfiles.00/ Bug: Refactor Hotspot mapfiles https://bugs.openjdk.java.net/browse/JDK-8065155 Summary of fix: After this fix, when you're adding a new JVM_XXX or JNI_XXX function, you no longer need to edit *9* files!! I checked the mapfiles of all platforms that are in the jdk9/hs-rt repo: [a] linux, solaris, bsd, bsd-darwin all have an identical common part that contains many JNI_ and JVM_ functions. [b] the common parts of linux, solaris and bsd are sorted in the same order. bsd-darwin is sorted differently but the contents are the same. [c] aix is slightly differently than the other platforms, probably due to code rot. So the fix is to move the common part into a separate file. I changed the makefiles of all platforms to concatenate the common part into the main mapfile. As part of the fix, I also addressed: JDK-8134783 - libjvm.so is not rebuilt after mapfile-ext is modified Note that I have not tested AIX since I don't have a build environment. However, it should be no worse than before. Tests: JPRT (passed) RBT (will do it before pushing) Thanks - Ioi
-- Bertrand Delsart, Grenoble Engineering Center Oracle, 180 av. de l'Europe, ZIRST de Montbonnot 38330 Montbonnot Saint Martin, FRANCE bertrand.dels...@oracle.com Phone : +33 4 76 18 81 23 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ NOTICE: This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
