Because lots of people do not yet have VS2013.
The official compilers are not the only ones we should support.
They are just the ones RE uses.

I would call this a "must fix".

-phil.

On 09/29/2015 08:12 AM, Thomas Stüfe wrote:
Ok, I did not check this. Nevermind, then.

Kind Regards, Thomas

On Tue, Sep 29, 2015 at 4:25 PM, Daniel D. Daugherty <
[email protected]> wrote:

Ummm... VS2013 is the official compiler for JDK9 and Win*.
Why would we want to make a change to permit VS2010 to
continue to be used?

Dan


On 9/29/15 7:58 AM, Thomas Stüfe wrote:

Hi all,

please review this tiny change. It fixes the build on windows/Visual
Studio
2010 after "8046148: JEP 158: Unified JVM Logging".

strtoull() is missing from Visual Studio versions < 2013, but _strtoui64()
can be used instead.

webrev:
http://cr.openjdk.java.net/~stuefe/webrevs/8137329/webrev.00/webrev/
bug: https://bugs.openjdk.java.net/browse/JDK-8137329

Thanks & Kind Regards, Thomas



Reply via email to