Sorry for missing this review request. I'm still learning to deal
with my new e-mail filters (restored from memory after losing my
MacBook Pro env).
On 9/30/15 6:43 AM, Erik Joelsson wrote:
Hello,
Please approve and review this fix for 8u.
My last fix for this issue, JDK-8136691, was not enough. I made a
mistake while verifying the fix and the problem is still there.
There are more discrepancies between Solaris and the other platform
makefiles. The excludeSrc.gmk file is not included anywhere when
building on Solaris. The variable Src_Files_EXCLUDE is overwritten in
vm.make instead of appended to, so even when including excludeSrc.gmk,
it wasn't enough. The other platform specific buildtree.make files
also set INCLUDE_TRACE in the generated makefile.
Bug: https://bugs.openjdk.java.net/browse/JDK-8136980
Webrev: http://cr.openjdk.java.net/~erikj/8136980/webrev.hotspot.01/
make/solaris/makefiles/buildtree.make
No comments.
make/solaris/makefiles/vm.make
No comments.
Thumbs up.
Dan
/Erik
