On 9.10.2015 22:02, Alan Bateman wrote:
On 09/10/2015 20:48, Jan Lahoda wrote:
Hi,
I'd like to ask for a review of top-level and jdk repository changes
needed for the JShell/REPL tool.
The top-level repository changes:
http://cr.openjdk.java.net/~rfield/jshell_base_webrev_v0/
The jdk repository changes:
http://cr.openjdk.java.net/~rfield/jshell_jdk_webrev_v0/
Any feedback is welcome.
Looks okay to me, just surprised to see the dependence on the
preferences API.
The reason for that dependency is that the JShell tool currently stores
the startup script/code (the code that is processed when the tool
starts) and the editing history using java.util.prefs.Preferences.
Thanks!
Jan
-Alan
