On 25/11/2015 08:11, Staffan Larsen wrote:
On 24 nov. 2015, at 17:03, Jaroslav Bachorik <jaroslav.bacho...@oracle.com>
wrote:
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8043138
Webrevs:
* top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top
* jdk: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/jdk
This patch splits up the jdk.jvmstat module to jdk.jvmstat and jdk.jvmstat.rmi
to make the basic jvmstat functionality available without requiring
dependencies on RMI.
The split is pretty straightforward - all the RMI dependent implementation is
moved to the new module as well as 'jstatd' implementation.
The change requires changes in the makefile (for merging META-INF/services
resources from jdk.jvmstat and jdk.jvmstat.rmi) and therefore I am posting this
request also to the build-dev mailing list.
Can you explain what the makefile is doing? Why do we need to merge these files?
Duplicates aren't allowed so these service configuration files need to
be merged. This build logic and the service configuration files will go
away once we bring the module system into JDK 9. This is because
classes/resources are stored by module and also we don't need service
configuration files (replaced by a 'provides' clause in the module
declaration).
-Alan
