On 2015-12-04 12:33, Magnus Ihse Bursie wrote:
Just a quick reply, I haven't looked at the new webrev yet.
4 dec. 2015 kl. 10:57 skrev Erik Joelsson <erik.joels...@oracle.com>:
I'm a bit curious why this fix was needed. I thought one of the idea with
BASIC_FIXUP_PATH was to guarantee that we pointed to an existing directory?
The documentation only says path, which I interpret as either a file or dir.
Hm. I think the intention was to verify an existing directory. I agree that the
name and documentation does not properly reflect this. Can you please verify
other users of this function, if they are all indeed looking for directories?
I'm just worried that this change will break the other uses, where it's
supposed that a proper, existing directory is returned. Can't you break out
common functionality and split this into two, a BASIC_FIXUP_DIR for the current
functionality, and a looser version that just verifies a path, be it a file or
not?
I really don't see how it could break anything. If you look a bit
further up, there is already a test that checks if the input "path" is
either a file or a dir, and if not prints an error. All I'm changing is
so the rewrite works both in both the file and dir case.
/Erik
