Re: [RFR] (XS) 8144677: jprt.properties should allow creating a user specified testset with custom build flavors and build targets

[Chris Plummer]

Thanks David!

Can I get a second reviewer please?

thanks,

Chris

On 12/6/15 3:52 PM, David Holmes wrote:

Hi Chris,

On 5/12/2015 7:00 AM, Chris Plummer wrote:

Hello,

Please review the following:

https://bugs.openjdk.java.net/browse/JDK-8144677
http://cr.openjdk.java.net/~cjplummer/8144677/webrev.01/webrev/

Tested with JPRT with:
   • "-testset hotspot"
   • "-testset svc"

• "-testset chris" from the example custom testset provided in the CR.

   • no testset specified

Looks good!

BTW, if anyone knows of an "include" mechanism for jprt.properties,

Properties files do not have an include mechanism. See:

http://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-

Thanks,
David

please let me know. Although that won't change the need for the above
changes, it would make it possible to put custom testsets in a file
rather than having to paste them in your ~/.jprt.properties file.

thanks,

Chris