Hi Magnus,
Thank you for reviewing!
I like the new way of passing a help text for deprecation. Just a note, in the help text you called
the new option "--with-debug-symbols" instead of "--with-native-debug-symbols",
which is kind of unhelpful. ;-) You can just fix this, no need to upload a new webrev.
Sorry, I've fixed it and pushed.
Thank you so much!
Yasumasa
On 2015/12/11 20:52, Magnus Ihse Bursie wrote:
On 2015-12-11 00:47, Yasumasa Suenaga wrote:
Hi build folks,
Could you review it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.06/
I like the new way of passing a help text for deprecation. Just a note, in the help text you called
the new option "--with-debug-symbols" instead of "--with-native-debug-symbols",
which is kind of unhelpful. ;-) You can just fix this, no need to upload a new webrev.
So, if you just fix this, I'm okay with the patch.
Thank you for fighting this all the way through. I do apologize for the slow
process.
/Magnus
