On 2016-02-08 20:37, Kim Barrett wrote:
On Feb 7, 2016, at 4:22 PM, Igor Ignatyev <igor.ignat...@oracle.com> wrote:
Hi Kim,
could you please take a look at the updated webrev:
http://cr.openjdk.java.net/~iignatyev/8144695/webrev.03
I agree that “+w” isn’t related to WARNINGS_ARE_ERRORS, so it was moved to
CFLAGS_WARN.
Regarding compiler version based conditions, I think it’d be better for build
team to decide how to deal w/ them.
PS I’ve checked that w/ the patch applied warnings, which normally cause a
build error, don’t cause any build errors w/ --disable-warnings-as-errors.
Looks good.
Looks good to me to, now.
/Magnus
