Goetz, Magnus - thanks for reviewing. Erik - thanks for pushing. Regards, Volker
On Wed, Apr 13, 2016 at 12:38 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > Looks good to me. > > /Magnus > > > 12 apr. 2016 kl. 18:03 skrev Volker Simonis <volker.simo...@gmail.com>: > > > > Hi, > > > > can I please have a review for the following trivial changes to make > > the build work again on AIX and Linux/ppc64le after the integration of > > the new hotspot build system. The changes are all AIX and/or ppc64 > > specific and shouldn't change the behavior on any other platform. > > > > Because the top-level changes require the rebuild of > > generated-configure.sh and the hotspot changes are in shared code, I > > also need a sponsor. It would be best if the changes could be pushed > > in sync to the hs-rt repository: > > > > http://cr.openjdk.java.net/~simonis/webrevs/2016/8154087.top > > http://cr.openjdk.java.net/~simonis/webrevs/2016/8154087.hs > > http://cr.openjdk.java.net/~simonis/webrevs/2016/8154087.jdk > > > > https://bugs.openjdk.java.net/browse/JDK-8154087 > > > > The hotspot change contains a trivial source code change in an AIX > > file to fix a warning which would otherwise break the build with > > "warnings as errors". > > > > The jdk change disables "warnings as errors" for AIX for several libs > > such that we can build the complete jdk with "warnings as errors" on > > AIX as well now. Fixing the actual warnings will be done in a later > > change. > > > > Thanks a lot and best regards, > > Volker >
