On 25/04/2016 22:01, Chris Hegarty wrote:
One of the remaining open issues in JEP 200 [1] is that the base module
exports the jdk.net package, thereby violating Principle 4 of JEP 200:
a Java SE module must not export any non-SE API packages without
qualification.
http://cr.openjdk.java.net/~chegar/8044773/
https://bugs.openjdk.java.net/browse/JDK-8044773
I took a first pass over this and it looks very good.
For the package name then sun.net.extnet repeats "net" and maybe
sun.net.ext would be better.
For the BaseExtendedSocketOptions then I think the FileDescriptor
parameter should be the first parameter as that is the file descriptor
to the socket that the methods operate on.
In ExtendedSocketOptions then I assume the toString is not needed in
checkValueType.
There are "TODOs" in the tests and I assume it would be better to drop
those and instead create an issue in JIRA to be addressed once jtreg is
promoted with support for -limitmods.
There is also a TODO in Sockets.java "check this is working ok" that I
assume needs attention before this is pushed.
-Alan
