> On May 12, 2016, at 1:37 AM, Erik Joelsson <erik.joels...@oracle.com> wrote: > > Assuming you meant [1] and that you actually tried it, this looks fine, > thanks! > > /Erik > > [1] http://cr.openjdk.java.net/~redestad/8156756/webrev.02/ >
Looks fine. Nit: 117 JLINK_ORDER_RESOURCES := \ 118 *module-info.class* \ 119 @$(SUPPORT_OUTPUTDIR)/classlist/classlist,/java.base/java/* \ Might be good to break “,/java.base/java/*” in a new line and space-separated to be consistent with the rest. Mandy
